Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Prerelease 8.5.0-alpha.3 #29528

Merged
merged 10 commits into from
Nov 5, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 4, 2024

This is an automated pull request that bumps the version from 8.5.0-alpha.2 to 8.5.0-alpha.3.
Once this pull request is merged, it will trigger a new release of version 8.5.0-alpha.3.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: Core: Prevent clipping box shadow on file search modal #29523
  • 🐛 Bug: Addon Test: Fix post-install logic for Next.js Vite framework support #29524 (will also be patched)
  • 📝 Documentation: Next.js: Remove duplicate comments #29469
  • ⚠️ Direct commit: Fix type errors 9aa2f867d0fe3ca5ff9af933cf167d9982b9ba4f

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.5.0-alpha.3

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Nov 4, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

…shadow

Core: Prevent clipping box shadow on file search modal
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.5.0-alpha.2 branch from b35231e to 10028e3 Compare November 4, 2024 12:24
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.5.0-alpha.2 branch from 10028e3 to 8b42d51 Compare November 4, 2024 15:32
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.5.0-alpha.2 branch 3 times, most recently from e252762 to 39952ac Compare November 5, 2024 02:22
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.5.0-alpha.2 branch from 39952ac to e9d6e29 Compare November 5, 2024 02:32
@shilman shilman added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Nov 5, 2024
Copy link

nx-cloud bot commented Nov 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e9d6e29. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@shilman shilman merged commit 22f8ad4 into next-release Nov 5, 2024
108 of 112 checks passed
@shilman shilman deleted the version-non-patch-from-8.5.0-alpha.2 branch November 5, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants