Release: Prerelease 8.5.0-alpha.2 #29508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
In a pnpm monorepo with multiple Next.js projects, different projects can have different peerDependencies for Next.js, which causes pnpm to install multiple instances of the `next` package in the monorepo. In this situation, prior to this change, Storybook's webpack configuration could consume `react` from one instance of Next and `react-dom` from another, causing React render errors due to the mismatch.
This issue was caused by the `configureConfig` function adding webpack module aliases for `react` using `addScopedAlias` (which generates an alias with an absolute filesystem path pointing to the correct instance of `next`, e.g. `'/path/to/next/dist/compiled/react'`), but adding module aliases for `react-dom` using `setAlias` (which generates an alias with a relative path, e.g. `'next/dist/compiled/react-dom'`).
This would create a webpack configuration like this:
```
alias: {
⋮
react: '/Users/kyank/Developer/authentication-ui/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_babel-plugin_z4uy3ayinaafvek4wmyon66ziu/node_modules/next/dist/compiled/react',
⋮
'react-dom/test-utils': 'next/dist/compiled/react-dom/cjs/react-dom-test-utils.production.js',
'react-dom$': 'next/dist/compiled/react-dom',
'react-dom/client': 'next/dist/compiled/react-dom/client',
'react-dom/server': 'next/dist/compiled/react-dom/server',
⋮
},
```
This change uses `addScopedAlias` to create aliases with absolute filesystem paths for all of the Next.js-bundled React packages. This fixes the React rendering errors in our monorepo.
This issue seems to have been [introduced in Storybook 8.3.0](https://github.com/storybookjs/storybook/pull/29044/files#diff-20144c44999f6f1054f74f56ef1c3fcfcec008fd7b5caea5e10568e95eccb051).
Build: Gracefully handle empty folders on dev machines
Core: Add bun support with npm fallback
Chore: Improve varous aspects of sandbox creation
…norepo Next.js: Fix bundled react and react-dom in monorepos
Next.js: Upgrade sass-loader from ^13.2.0 to ^14.2.1
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
17 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
.github/PULL_REQUEST_TEMPLATE.md
Outdated
Comment on lines
76
to
78
| <!-- BENCHMARK_SECTION --> | ||
| <!-- BENCHMARK_SECTION --> No newline at end of file | ||
| <!-- BENCHMARK_SECTION --> |
There was a problem hiding this comment.
style: Duplicate BENCHMARK_SECTION tags - one should be removed
Comment on lines
+259
to
+262
| error, | ||
| packageManager: 'NPM', | ||
| packageName, | ||
| }); |
There was a problem hiding this comment.
logic: Error message shows NPM as package manager even though this is the Bun proxy. Should show Bun instead.
Comment on lines
+309
to
+310
| infoCommand: 'npm ls --depth=1', | ||
| dedupeCommand: 'npm dedupe', |
There was a problem hiding this comment.
style: Info and dedupe commands show npm commands but should reflect Bun equivalents if they exist
| @@ -354,6 +355,91 @@ describe('CLASS: JsPackageManagerFactory', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Yarn 2 proxy', () => { | |||
There was a problem hiding this comment.
logic: This entire test suite is duplicated from lines 280-356. It should be removed and the Bun test cases should be added as a separate 'Bun proxy' test suite.
| @@ -136,6 +146,18 @@ function hasNPM(cwd?: string) { | |||
| return npmVersionCommand.status === 0; | |||
| } | |||
|
|
|||
| function hasBun(cwd?: string) { | |||
| const pnpmVersionCommand = spawnSync('bun', ['--version'], { | |||
There was a problem hiding this comment.
style: Variable name should be 'bunVersionCommand' instead of 'pnpmVersionCommand' for consistency
| @@ -22,7 +23,7 @@ export async function setupYarn({ cwd, pnp = false, version = 'classic' }: Setup | |||
|
|
|||
| export async function localizeYarnConfigFiles(baseDir: string, beforeDir: string) { | |||
| await Promise.allSettled([ | |||
| runCommand(`touch yarn.lock`, { cwd: beforeDir }), | |||
| fs.writeFileSync(join(beforeDir, 'yarn.lock'), '', { flag: 'a' }), | |||
There was a problem hiding this comment.
logic: writeFileSync is being used in a Promise.allSettled array but it returns void, not a Promise. This could cause unexpected behavior.
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.1
branch
from
d490572 to
cea8510
Compare
…lugin Build: Shim CJS-only globals in ESM output
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.1
branch
from
cea8510 to
5e8aa5e
Compare
…n-prod Addon Test: Only render the TestingModule component in development mode
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.1
branch
from
5e8aa5e to
01fbde8
Compare
Core: Add support for groups to `TooltipLinkList` and use it for main Storybook menu
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.1
branch
from
01fbde8 to
eea0387
Compare
CLI: Fix Solid init by installing `@storybook/test`
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.1
branch
from
eea0387 to
fe3edcc
Compare
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.1
branch
from
fe3edcc to
2a0de12
Compare
shilman
added
freeze
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2a0de12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.0-alpha.1to8.5.0-alpha.2.Once this pull request is merged, it will trigger a new release of version
8.5.0-alpha.2.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:@storybook/test#29514 (will also be patched)TooltipLinkListand use it in main menu #29507If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-alpha.2
@storybook/test- #29514, thanks @shilman!TooltipLinkListand use it in main menu - #29507, thanks @ghengeveld!