Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Addon Test: Error when addon interactions exists" #29433

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Oct 23, 2024

Reverts #29338

Greptile Summary

This PR reverts changes related to conflict detection between Storybook addon-interactions and addon-test, simplifying addon configuration.

  • Reintroduced '@storybook/addon-interactions' in code/.storybook/main.ts addons array
  • Removed ADDON_INTERACTIONS_IN_USE constant from code/addons/interactions/src/preset.ts
  • Removed conflict check, previewAnnotations, and managerEntries functions from code/addons/test/src/preset.ts
  • Retained checkActionsLoaded function in both addon presets for proper addon order

@valentinpalkovic valentinpalkovic merged commit 011c6fc into unified-ui-testing Oct 23, 2024
@valentinpalkovic valentinpalkovic deleted the revert-29338-yann/addon-interactions-conflict branch October 23, 2024 14:21
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Oct 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ce8dd08. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant