Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextjs: Make sure Next 14 is used for sandboxes #29430

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Oct 23, 2024

Closes #

What I did

Make sure Next 14 is used for sandboxes

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.7 MB 77.7 MB 0 B -4.35 0%
initSize 146 MB 146 MB 0 B -4.28 0%
diffSize 68.5 MB 68.5 MB 0 B 3.94 0%
buildSize 7.1 MB 7.1 MB 0 B 4.36 0%
buildSbAddonsSize 1.79 MB 1.79 MB 0 B 4.36 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.85 MB 1.85 MB 0 B 4.1 0%
buildSbPreviewSize 271 kB 271 kB 0 B 4.36 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.1 MB 4.1 MB 0 B 4.36 0%
buildPreviewSize 3 MB 3 MB 0 B 4.36 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 13s 7.6s -5s -410ms -0.8 -70.6%
generateTime 25.4s 24.3s -1s -93ms 0.34 -4.5%
initTime 17.8s 17.3s -424ms 0.42 -2.4%
buildTime 10.8s 8.7s -2s -157ms -0.24 -24.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.7s 5.2s -487ms -1.25 🔰-9.3%
devManagerResponsive 4.2s 3.7s -550ms -0.83 -14.8%
devManagerHeaderVisible 591ms 507ms -84ms -0.63 -16.6%
devManagerIndexVisible 627ms 536ms -91ms -0.64 -17%
devStoryVisibleUncached 1.2s 882ms -349ms -0.46 -39.6%
devStoryVisible 626ms 535ms -91ms -0.66 -17%
devAutodocsVisible 600ms 448ms -152ms -0.62 -33.9%
devMDXVisible 535ms 435ms -100ms -0.83 -23%
buildManagerHeaderVisible 576ms 477ms -99ms -0.61 -20.8%
buildManagerIndexVisible 587ms 492ms -95ms -0.68 -19.3%
buildStoryVisible 567ms 479ms -88ms -1.17 -18.4%
buildAutodocsVisible 492ms 441ms -51ms -0.49 -11.6%
buildMDXVisible 458ms 401ms -57ms -1.02 -14.2%

Greptile Summary

Updated Next.js sandbox templates to use version 14 and modified Yarn configuration to handle peer dependency errors for all Next.js sandboxes.

  • Updated nextjs/default-js and nextjs/default-ts templates in code/lib/cli-storybook/src/sandbox-templates.ts to use Next.js 14.2.16
  • Modified configureYarn2ForVerdaccio function in scripts/utils/yarn.ts to disable INCOMPATIBLE_PEER_DEPENDENCY errors for all Next.js sandboxes
  • Ensured consistent and up-to-date environment for Next.js sandboxes in Storybook
  • Removed '/prerelease' suffix from 'nextjs' check in Yarn configuration to apply changes to all Next.js sandboxes

@kasperpeulen kasperpeulen changed the title Make sure Next 14 is used for sandboxes Nextjs: Make sure Next 14 is used for sandboxes Oct 23, 2024
@kasperpeulen kasperpeulen added ci:daily Run the CI jobs that normally run in the daily job. build Internal-facing build tooling & test updates labels Oct 23, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Oct 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 63ddd1c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen force-pushed the kasper/fix-sandboxes-next branch from 7ea466b to 322e4ca Compare October 24, 2024 07:56
@kasperpeulen kasperpeulen force-pushed the kasper/fix-sandboxes-next branch from 322e4ca to d0830cf Compare October 24, 2024 09:37
@kasperpeulen kasperpeulen merged commit 99b7c67 into next Oct 24, 2024
111 checks passed
@kasperpeulen kasperpeulen deleted the kasper/fix-sandboxes-next branch October 24, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants