-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Fix broken and outdated documentation links #29412
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5008cb4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
29 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, great clean up work!! ❤️
I left one comment to be addressed, but will go ahead and approve to unblock you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the underlying bug that was breaking a bunch of redirects. It's definitely better to have the canonical URLs being used everywhere, though, so this PR is still great.
The one exception is that some of the migration guide links pertain specifically to SB 8 features, so those should retain the version in the URL. I've left comments calling each of those out.
code/lib/cli-storybook/src/automigrate/fixes/remove-legacymdx1.ts
Outdated
Show resolved
Hide resolved
code/lib/cli-storybook/src/automigrate/fixes/vite-config-file.ts
Outdated
Show resolved
Hide resolved
code/lib/cli-storybook/src/automigrate/fixes/vite-config-file.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Kyle Gach <[email protected]>
Co-authored-by: Kyle Gach <[email protected]>
Co-authored-by: Kyle Gach <[email protected]>
Closes #29352
With this pull request, the links included in the monorepo were updated to address the recent updates to the documentation, preventing them from generating errors (e.g., 404 and 500).
What was done:
This body of work may require patching back to the
main
branch and released as a patch version. I would leave it up to the rest of the maintainers to address how best to proceed.Greptile Summary
Updated documentation links across multiple files in the Storybook codebase to fix broken and outdated references.