-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Migration guide updates for Angular Initializer changes in v7 #29397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rdebeasi, thanks for putting together this pull request and helping improve the migration guide with this important information. Appreciate it 🙏 ! I left one small item for you to look into when you can.
Let me know once you've addressed it, and I'll gladly merge this one.
@valentinpalkovic thanks for taking a look into this as well 🙏
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b0e056c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Co-authored-by: jonniebigodes <[email protected]>
Updated. Thank you for taking a look! |
@rdebeasi thanks for addressing the feedback! Appreciate it 🙏 ! I'll gladly merge this once the checklist clears. Have a great day. Stay safe |
Related to #22674 (already closed) and #29386 (might close; I'm not sure).
What I did
I documented a breaking change in Storybook v7, per this recommendation. I also described the update I made to account for this change. If there's a better alternative - or if you'd prefer for me to remove that code snippet - just let me know!
I noticed that my editor removed some escaping and adjusted some whitespace. I think these changes are in line with the standards for this file, but I can back those changes out if they're incorrect.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
(Not applicable - documentation only)
Manual testing
This change includes documentation only.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This pull request updates documentation to cover changes discussed in issue #22674, which was related to Angular's APP_INITIALIZER not firing in Storybook 7. The main changes include:
Key points:
This update should improve the migration guide for Angular users upgrading to Storybook 7 or 8, helping them understand and address potential issues with APP_INITIALIZER.