Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix GitHub action example #29393

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

Mahdi-Hazrati
Copy link
Contributor

@Mahdi-Hazrati Mahdi-Hazrati commented Oct 18, 2024

update node version from 16 to 20, for can build next js latest

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This pull request updates the Node.js version from 16.x to 20.x in the GitHub Actions workflow for building and publishing Storybook to GitHub Pages.

  • Updated Node.js version to 20.x in docs/_snippets/ghp-github-action.md
  • Addresses a building issue in GitHub Pages for latest Next.js applications
  • Ensures compatibility with newer Node.js features and improvements
  • May require verification of compatibility with existing dependencies and functionality

update node version from 16 to 20, for can build next js latest
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@jonniebigodes jonniebigodes self-assigned this Oct 21, 2024
@jonniebigodes jonniebigodes changed the title Update node version to 20 Fix building issue in GitHub pages Docs: Update node version to 20 Fix building issue in GitHub pages Oct 21, 2024
@jonniebigodes jonniebigodes changed the title Docs: Update node version to 20 Fix building issue in GitHub pages Docs: Fix GitHub action example Oct 21, 2024
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mahdi-Hazrati, thanks for taking the time to put together this example and helping us improve the documentation by catching this minor issue with our examples. We appreciate it 🙏 ! I've checked, and everything is good on my end.

I'll gladly merge this once the checklist clears.

Have a fantastic week.

Stay safe

@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Oct 21, 2024
Copy link

nx-cloud bot commented Oct 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4f65b1b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes merged commit 52a345b into storybookjs:next Oct 21, 2024
8 checks passed
@Mahdi-Hazrati
Copy link
Contributor Author

@Mahdi-Hazrati, thanks for taking the time to put together this example and helping us improve the documentation by catching this minor issue with our examples. We appreciate it 🙏 ! I've checked, and everything is good on my end.

I'll gladly merge this once the checklist clears.

Have a fantastic week.

Stay safe

Thank you so much for your kind words and support! 🙌 I'm really glad I could contribute and help improve the documentation. It's been a great experience working with the Storybook team and community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants