Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move builds to core #2937

Merged
merged 7 commits into from
Feb 7, 2018
Merged

Move builds to core #2937

merged 7 commits into from
Feb 7, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Feb 7, 2018

Issue: #2636

What I did

  1. Moved index.js to core
  2. Moved build.js to core
  3. Fixed polymer leftovers - (UglifyJsPlugin and getConfigDir)
  4. Moved WatchMissingNodeModulesPlugin to core

@igor-dv igor-dv self-assigned this Feb 7, 2018
@codecov
Copy link

codecov bot commented Feb 7, 2018

Codecov Report

Merging #2937 into master will increase coverage by 1.38%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2937      +/-   ##
==========================================
+ Coverage   35.99%   37.38%   +1.38%     
==========================================
  Files         429      426       -3     
  Lines        9503     9150     -353     
  Branches      976      869     -107     
==========================================
  Hits         3421     3421              
+ Misses       5438     5226     -212     
+ Partials      644      503     -141
Impacted Files Coverage Δ
app/angular/src/server/utils.js 0% <ø> (ø) ⬆️
app/vue/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/react/src/server/utils.js 100% <ø> (+100%) ⬆️
app/angular/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js 0% <ø> (ø)
...p/polymer/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
app/polymer/src/server/utils.js 0% <ø> (-53.58%) ⬇️
lib/core/src/server/middleware.js 0% <ø> (ø)
app/vue/src/server/utils.js 0% <ø> (ø) ⬆️
app/polymer/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86bad1...7af0e56. Read the comment docs.

@Hypnosphi Hypnosphi merged commit a78016c into master Feb 7, 2018
@Hypnosphi Hypnosphi added the cleanup Minor cleanup style change that won't show up in release changelog label Feb 7, 2018
@Hypnosphi Hypnosphi deleted the more-builds-to-core branch February 7, 2018 16:27
@Hypnosphi
Copy link
Member

WatchMissingNodeModulesPlugin is actually a part of react-dev-utils package which we already depend on, in all apps (I guess, react is in the package name only because it's a part of create-react-app project. Let's import it from there instead of replicating on our side

@igor-dv
Copy link
Member Author

igor-dv commented Mar 3, 2018

Makes sense to me

@Hypnosphi
Copy link
Member

Ok, I'll make a PR

@Hypnosphi
Copy link
Member

#3141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular cleanup Minor cleanup style change that won't show up in release changelog core maintenance User-facing maintenance tasks react vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants