Release: Prerelease 8.4.0-alpha.7 #29332
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Docs: Add streamlined a11y setup docs
CLI: Install Svelte CSF v5 in Svelte5 projects
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
10 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
| ['6.0.0', ''], | ||
| ['3.0.0-next.0', ''], | ||
| ['4.0.0-next.0', '4'], | ||
| ['4.2.19::__archiveUrl=https%3A%2F%2Fregistry.npmjs.org%2Fsvelte%2F-%2Fsvelte-4.2.19.tgz', '4'], |
There was a problem hiding this comment.
style: Consider using a constant for this long URL to improve readability
| const packageManager = { | ||
| getInstalledVersion: async (pkg: string) => (pkg === 'svelte' ? svelteVersion : undefined), | ||
| getAllDependencies: async () => ({ svelte: `^${svelteVersion}` }), | ||
| } as any as JsPackageManager; |
There was a problem hiding this comment.
style: Avoid using 'any' type casting. Consider creating a mock object that implements the JsPackageManager interface
| const packageManager = { | ||
| getInstalledVersion: async (pkg: string) => undefined, | ||
| getAllDependencies: async () => ({ svelte: svelteSpecifier }), | ||
| } as any as JsPackageManager; |
There was a problem hiding this comment.
style: Avoid using 'any' type casting here as well. Create a mock object implementing JsPackageManager
| const versionHelper = (svelteMajor?: number) => { | ||
| if (svelteMajor === 4) { | ||
| return '4'; | ||
| } | ||
| // TODO: update when addon-svelte-csf v5 is released | ||
| if (svelteMajor === 5) { | ||
| return '^5.0.0-next.0'; | ||
| } | ||
| return ''; | ||
| }; |
There was a problem hiding this comment.
style: consider using a switch statement for better readability and maintainability
…gs-intersection Manager: Add tags property to ComponentEntry objects
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.6
branch
from
2c33d2a to
48915df
Compare
shilman
added
freeze
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 48915df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
This is an automated pull request that bumps the version from
8.4.0-alpha.6to8.4.0-alpha.7.Once this pull request is merged, it will trigger a new release of version
8.4.0-alpha.7.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.4.0-alpha.7