Vite: Cleanup and prebundle dependencies #29302
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 21f4ff1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
| // TODO: framework doesn't exist, should move into framework when/if built | ||
| if (frameworkName === '@storybook/glimmerx-vite') { | ||
| const plugin = require('vite-plugin-glimmerx/index.cjs'); | ||
| plugins.push(plugin.default()); | ||
| } | ||
|
|
There was a problem hiding this comment.
just cleaned up a bit. @storybook/glimmerx-vite has never existed, this code path can never been triggered, and it doesn't seem like there's been any movement in glimmerx for 3 years.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
Did you also check these numbers in "real" applications? Almost every vite / rollup / esbuild plugin uses magic-string if it performs code source manipulation. Other popular usage relevant for storybook are vue and vitest. Thus there is a very high chance that once you use vite, you already have magic-string in your dependency tree. Thus, if you bundle it, then the actual install size increases. Based on the install numbers, a similar argument can probably be made for find-cache-dir. |
Works on #29038
What I did
Sources
https://pkg-size.dev/@storybook%[email protected]?no-peers
https://pkg-size.dev/@storybook%[email protected]?no-peers
https://npmgraph.js.org/?q=@storybook/[email protected]#hide=
https://npmgraph.js.org/?q=@storybook/[email protected]#zoom=w
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-29302-sha-21f4ff11. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-29302-sha-21f4ff11jeppe/prebundle-builder-vite21f4ff111728418997)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29302Greptile Summary
This PR optimizes the @storybook/builder-vite package by simplifying dependencies and removing specific configurations.
code/builders/builder-vite/package.jsonpackage.json, potentially reducing package sizecode/builders/builder-vite/src/vite-config.ts