Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Update the React Native init to include v8 dependencies #29273

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Oct 3, 2024

Closes #

What I did

I've added new dependencies for react native storybook v8 so we can be ready to release

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.5 MB 78.5 MB 102 B 2.92 0%
initSize 151 MB 151 MB 3.47 kB -0.55 0%
diffSize 72.6 MB 72.6 MB 3.37 kB -0.71 0%
buildSize 6.77 MB 6.77 MB 0 B -1.09 0%
buildSbAddonsSize 1.5 MB 1.5 MB 0 B -1.11 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.83 MB 1.83 MB 0 B -1.07 0%
buildSbPreviewSize 270 kB 270 kB 0 B -1.11 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.8 MB 3.8 MB 0 B -1.09 0%
buildPreviewSize 2.97 MB 2.97 MB 0 B -1.45 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 16.7s 12s -4s -773ms -0.33 -39.7%
generateTime 18.7s 30s 11.3s 3.34 🔺37.7%
initTime 13.2s 15.8s 2.6s 0.45 16.6%
buildTime 8.8s 9.3s 428ms -0.5 4.6%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 8.3s 7.1s -1s -148ms -0.06 -16%
devManagerResponsive 5.7s 4.5s -1s -153ms -0.09 -25.2%
devManagerHeaderVisible 545ms 580ms 35ms -0.36 6%
devManagerIndexVisible 574ms 615ms 41ms -0.34 6.7%
devStoryVisibleUncached 1.2s 1.3s 92ms 0.33 7%
devStoryVisible 573ms 613ms 40ms -0.37 6.5%
devAutodocsVisible 459ms 591ms 132ms 0.61 22.3%
devMDXVisible 455ms 630ms 175ms 0.74 27.8%
buildManagerHeaderVisible 532ms 647ms 115ms 0.47 17.8%
buildManagerIndexVisible 560ms 719ms 159ms 0.72 22.1%
buildStoryVisible 562ms 720ms 158ms 0.6 21.9%
buildAutodocsVisible 490ms 501ms 11ms -0.3 2.2%
buildMDXVisible 538ms 507ms -31ms -0.16 -6.1%

Greptile Summary

Updated React Native generator for Storybook version 8, focusing on new dependencies and setup process.

  • Added new peer dependencies in code/lib/create-storybook/src/generators/REACT_NATIVE/index.ts
  • Updated language version to TypeScript 4.9 for React Native template
  • Modified code/lib/create-storybook/src/initiate.ts to include new setup instructions for React Native projects
  • Introduced 'withStorybook' enhancer function for Metro config in React Native setup
  • Adjusted package installation process for React Native Storybook integration

Copy link

nx-cloud bot commented Oct 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d395e02. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@dannyhw dannyhw changed the title React Native: Update the init generator to include new dependencies React Native: Update the init generator to include new dependencies for v8 Oct 3, 2024
@dannyhw dannyhw added maintenance User-facing maintenance tasks ci:normal labels Oct 3, 2024
@dannyhw dannyhw marked this pull request as ready for review October 3, 2024 20:03
@dannyhw dannyhw requested a review from shilman October 3, 2024 20:03
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 3, 2024
@shilman shilman changed the title React Native: Update the init generator to include new dependencies for v8 CLI: Update the React Native init to include new dependencies for v8 Oct 3, 2024
@shilman shilman changed the title CLI: Update the React Native init to include new dependencies for v8 CLI: Update the React Native init to include v8 dependencies Oct 3, 2024
@shilman shilman merged commit 3988207 into next Oct 3, 2024
66 of 72 checks passed
@shilman shilman deleted the dannyhw/feat/rnv8-update-create-generator branch October 3, 2024 22:29
shilman added a commit that referenced this pull request Oct 4, 2024
…reate-generator

CLI: Update the React Native init to include v8 dependencies
(cherry picked from commit 3988207)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants