Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvelteKit/Vue3: Refactor plugin export paths #29016

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 30, 2024

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.5 MB 76.5 MB 0 B 1.17 0%
initSize 161 MB 161 MB 0 B 0.08 0%
diffSize 84.8 MB 84.8 MB 0 B 0.07 0%
buildSize 7.48 MB 7.48 MB 0 B 0.51 0%
buildSbAddonsSize 1.62 MB 1.62 MB 0 B 1.11 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.31 MB 2.31 MB 0 B 0.5 0%
buildSbPreviewSize 352 kB 352 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.47 MB 4.47 MB 0 B 0.5 0%
buildPreviewSize 3.01 MB 3.01 MB 0 B 0.53 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 8.6s 15s 6.4s -0.07 42.7%
generateTime 23.4s 22.3s -1s -127ms 0.03 -5%
initTime 19.3s 17s -2s -331ms -0.26 -13.7%
buildTime 10.7s 13.4s 2.6s 0.56 20%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.9s 6s -842ms -1.22 -13.8%
devManagerResponsive 4.4s 3.9s -480ms -1.26 🔰-12.1%
devManagerHeaderVisible 777ms 709ms -68ms -0.8 -9.6%
devManagerIndexVisible 817ms 744ms -73ms -0.83 -9.8%
devStoryVisibleUncached 1.4s 817ms -585ms -1.18 -71.6%
devStoryVisible 814ms 743ms -71ms -0.83 -9.6%
devAutodocsVisible 738ms 618ms -120ms -0.98 -19.4%
devMDXVisible 662ms 597ms -65ms -1.09 -10.9%
buildManagerHeaderVisible 782ms 641ms -141ms -1.1 -22%
buildManagerIndexVisible 784ms 646ms -138ms -1.14 -21.4%
buildStoryVisible 859ms 676ms -183ms -1.33 🔰-27.1%
buildAutodocsVisible 689ms 627ms -62ms -0.84 -9.9%
buildMDXVisible 749ms 653ms -96ms -0.23 -14.7%

Greptile Summary

This PR refactors the Vite plugin export paths for SvelteKit and Vue3 frameworks in Storybook, improving consistency and maintainability.

  • Renamed 'vite.ts' to 'vite-plugin.ts' in both SvelteKit and Vue3-Vite frameworks
  • Updated export paths in package.json files for both frameworks to reflect the new file names
  • Simplified plugin exports to single functions in 'vite-plugin.ts' files
  • Modified 'scripts/tasks/sandbox-parts.ts' to use updated import paths for Vite plugins
  • Updated 'code/addons/vitest/src/postinstall.ts' with new import paths for SvelteKit and Vue3 Vite plugins

@yannbf yannbf added maintenance User-facing maintenance tasks vue3 ci:merged Run the CI jobs that normally run when merged. sveltekit labels Aug 30, 2024
Copy link

nx-cloud bot commented Aug 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 82cf64d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@shilman shilman added ci:merged Run the CI jobs that normally run when merged. and removed ci:merged Run the CI jobs that normally run when merged. labels Aug 30, 2024
@shilman shilman force-pushed the yann/rename-vite-plugin-exports branch from 5f13f79 to 6fdc8af Compare August 30, 2024 18:20
@shilman shilman force-pushed the yann/rename-vite-plugin-exports branch from 6fdc8af to 82cf64d Compare August 31, 2024 02:41
@yannbf yannbf merged commit 411c3cc into next Sep 2, 2024
66 of 68 checks passed
@yannbf yannbf deleted the yann/rename-vite-plugin-exports branch September 2, 2024 12:35
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
9 tasks
@shilman shilman changed the title Maintenance: Refactor plugin export paths in SvelteKit and Vue3 SvelteKit/Vue3: Refactor plugin export paths Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:merged Run the CI jobs that normally run when merged. maintenance User-facing maintenance tasks sveltekit vue3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants