Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Remove scorecards yaml #28623

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Build: Remove scorecards yaml #28623

merged 1 commit into from
Aug 2, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 16, 2024

What I did

This PR introduced this:
#19755

However it fails:
https://github.com/storybookjs/storybook/actions/runs/9956351802/job/27506067221

I'm opening this to either remove, or get a conversation started to work out how to fix it.

The tool seems linked to https://app.stepsecurity.io/scorecard/securerepo/storybookjs/storybook/publish.yml/next?repo=storybookjs/storybook

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Removed /.github/workflows/scorecards.yml file
  • Discontinued Scorecards analysis tool integration

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 461e9b8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen self-assigned this Jul 16, 2024
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. labels Jul 16, 2024
@ndelangen ndelangen merged commit b94ead3 into next Aug 2, 2024
11 of 13 checks passed
@ndelangen ndelangen deleted the norbert/remove-scorecards branch August 2, 2024 21:27
@github-actions github-actions bot mentioned this pull request Aug 2, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants