Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Controls: Fix saving on Windows #28485

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

ghengeveld
Copy link
Member

What I did

This fixes Save from Controls on Windows where some bad regular expression matching caused Node to hang. The issue was some missing escape characters which caused actual newlines to appear in the production bundle after transpilation, rather than \n literals. Escaping these characters resolves that problem.

ChatGPT suggested replacing .|\r\n|\r|\n with [\s|\S] which matches the same thing (anything) but in a more elegant and efficient manner.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Fixed regex pattern in /code/core/src/core-server/utils/save-story/save-story.ts to prevent Node from hanging on Windows
  • Replaced (.|\r\n|\r|\n) with [\s\S] for better efficiency and correctness

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit df1a772. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic added ci:daily Run the CI jobs that normally run in the daily job. ci:normal and removed ci:normal ci:daily Run the CI jobs that normally run in the daily job. labels Jul 8, 2024
@valentinpalkovic valentinpalkovic merged commit d749cf2 into next Jul 8, 2024
61 of 72 checks passed
@valentinpalkovic valentinpalkovic deleted the fix-regex-escaping branch July 8, 2024 18:33
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants