-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Add args to mount
in react, svelte, and vue renderers
#28385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 61d0ddf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
kasperpeulen
force-pushed
the
kasper/mount-args
branch
from
June 28, 2024 13:47
38bf530
to
cae31b1
Compare
kasperpeulen
requested review from
tmeasday,
valentinpalkovic,
ghengeveld and
yannbf
June 28, 2024 13:51
tmeasday
reviewed
Jul 1, 2024
8 tasks
yannbf
reviewed
Jul 1, 2024
# Conflicts: # code/renderers/react/src/types.ts # code/renderers/svelte/src/types.ts # code/renderers/vue3/src/public-types.test.ts # code/renderers/vue3/src/types.ts
shilman
changed the title
Test: Add args to the mount function in the react, svelte and vue renderer
Test: Add args to Jul 3, 2024
mount
in react, svelte, and vue renderers
yannbf
approved these changes
Jul 3, 2024
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This add the ability to mount a specific element in the play function itself, similar as how you do it in testing library.
For React:
storybook/code/renderers/react/template/stories/mount-in-play.stories.tsx
Lines 13 to 20 in 530c0ef
For Svelte:
storybook/code/renderers/svelte/template/stories/mount-in-play.stories.ts
Lines 8 to 15 in 530c0ef
For Vue3:
storybook/code/renderers/vue3/template/stories_vue3-vite-default-ts/mount-in-play.stories.ts
Lines 13 to 20 in 530c0ef
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-28385-sha-61d0ddf0
. Try it out in a new sandbox by runningnpx [email protected] sandbox
or in an existing project withnpx [email protected] upgrade
.More information
0.0.0-pr-28385-sha-61d0ddf0
kasper/mount-args
61d0ddf0
1719992540
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28385