Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-interactions: Fix deprecation warnings #28250

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 15, 2024

Closes #26595

What I did

Remove deprecated button parameters, finishing work started in #25822 (cc @cdedreuille )

Checklist for Contributors

Testing

Manual testing ✅

  1. Open a sandbox & open a story that uses addon-interactions, such as Header's LoggedIn story.
  2. Open the Interactions addon panel
  3. Verify that there are no deprecation warnings in the browser console

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@shilman shilman added bug ui patch:yes Bugfix & documentation PR that need to be picked to main branch addon: interactions ci:normal labels Jun 15, 2024
Copy link

nx-cloud bot commented Jun 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c31503f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman
Copy link
Member Author

shilman commented Jun 15, 2024

Self-merging @cdedreuille

@shilman shilman merged commit 9412e07 into next Jun 15, 2024
59 of 61 checks passed
@shilman shilman deleted the shilman/26595-fix-interactions-deprecations branch June 15, 2024 12:47
storybook-bot pushed a commit that referenced this pull request Jun 15, 2024
…ions-deprecations

Addon-interactions: Fix deprecation warnings
(cherry picked from commit 9412e07)
storybook-bot pushed a commit that referenced this pull request Jun 17, 2024
…ions-deprecations

Addon-interactions: Fix deprecation warnings
(cherry picked from commit 9412e07)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: interactions bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Interactions-Addon still uses deprecated Button props
1 participant