Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: bump markdown-to-jsx to v7.4.5 #26694

Merged
merged 2 commits into from
May 14, 2024

Conversation

xyy94813
Copy link
Contributor

@xyy94813 xyy94813 commented Mar 30, 2024

Don't see any breaking change in change logs of the markdown-to-jsx.
This version can resolve quantizor/markdown-to-jsx#529 and other bugs

What I did

  • bump markdown-to-jsx to v7.4.5 in workspace @storybook/blocks
  • bump markdown-to-jsx to v7.4.5 in workspace @storybook/manager
yarn workspace @storybook/blocks add markdown-to-jsx
yarn workspace @storybook/manager add markdown-to-jsx

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

I thing the follow testing is required.
And should be add to auto test

// test.md

[![latest version](https://img.shields.io/npm/v/markdown-to-jsx.svg?label=latest%20%20version)](https://www.npmjs.org/package/markdown-to-jsx)

#
##

----

other basic feature of Markdown
// @storybook/block -> Markdown.test.stories
import { Markdown } from "@storybook/blocks";
import Readme from "./test.md?raw";

<Markdown>{Readme}</Markdown>

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

don't see any breaking change in change logs of the lib.
This version can resolve quantizor/markdown-to-jsx#529 and other bugs
Copy link

nx-cloud bot commented Mar 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b9e316d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@xyy94813
Copy link
Contributor Author

xyy94813 commented May 2, 2024

Any problem?

@valentinpalkovic valentinpalkovic changed the title chore: bump markdown-to-jsx to v7.4.5 Dependency: bump markdown-to-jsx to v7.4.5 May 14, 2024
@valentinpalkovic valentinpalkovic merged commit 1e4aadc into storybookjs:next May 14, 2024
50 of 52 checks passed
@github-actions github-actions bot mentioned this pull request May 14, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Error when the content of the link is an image marker
2 participants