-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composition: Fix refs not loading when there's multiple #26356
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4e723fe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
I think lines 175 and 176 needs to be adjusted as well to await them and therefore, to be correct, |
@valentinpalkovic thank you, that's helpful. I've adjusted the code. |
Closes #26288
What I did
I also verified that the
url
field of a ref does in fact support a relative path!Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
I manually tested this using a special repro I setup (and will attach a zip for here).
repro-with-many-refs.zip
I copied the contents of
./code/ui/manager/dist
into{repro}/node_modules/@storybook/manager/dist
, and ran storybook.Before copying over, the storybook only loaded 1 or 2 refs. after the copy, all refs load in nicely, with clearly demonstrating the sequence happening. Honestly I kinda liked the effect.
composition-multiple-load.mov
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>