Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Fix type summary when table.type unset #26283

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Controls: Fix type summary when table.type unset #26283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b48135
Controls: Fix type summary
shilman Mar 2, 2024
2d386cb
Merge branch 'next' into shilman/fix-controls-type-summary
ndelangen Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion code/ui/blocks/src/components/ArgsTable/ArgRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,18 @@ const StyledTd = styled.td<{ expandable: boolean }>(({ theme, expandable }) => (
paddingLeft: expandable ? '40px !important' : '20px !important',
}));

const toSummary = (value: any) => {
if (!value) return value;
const val = typeof value === 'string' ? value : value.name;
return { summary: val };
};

export const ArgRow: FC<ArgRowProps> = (props) => {
const [isHovered, setIsHovered] = useState(false);
const { row, updateArgs, compact, expandable, initialExpandedArgs } = props;
const { name, description } = row;
const table = (row.table || {}) as TableAnnotation;
const type = table.type || row.type;
const type = table.type || toSummary(row.type);
const defaultValue = table.defaultValue || row.defaultValue;
const required = row.type?.required;
const hasDescription = description != null && description !== '';
Expand Down
Loading