-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portable stories: Improve existing APIs, add loaders support #26267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
JReinhold
reviewed
Mar 1, 2024
code/lib/preview-api/src/modules/store/csf/portable-stories.test.ts
Outdated
Show resolved
Hide resolved
code/lib/preview-api/src/modules/store/csf/portable-stories.test.ts
Outdated
Show resolved
Hide resolved
JReinhold
reviewed
Mar 1, 2024
10 tasks
yannbf
force-pushed
the
feature/portable-stories-optional-context
branch
from
March 4, 2024 10:54
cfb4efc
to
5430cf4
Compare
yannbf
changed the title
Portable stories: Make canvasElement optional in the play function
Portable stories: Improve existing APIs, add loaders support
Mar 4, 2024
…st.ts Co-authored-by: Jeppe Reinhold <[email protected]>
yannbf
force-pushed
the
feature/portable-stories-optional-context
branch
from
March 4, 2024 10:58
5430cf4
to
6dae91d
Compare
JReinhold
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ❤️
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26251
What I did
This PR adds a few (big impact) bug fixes to the portable stories APIs:
It also adds the following features/improvements:
Apart from the fixes, this PR introduces a breaking change to a portable story's play function, described below:
When reusing a story that has a play function, you don't have to pass the context anymore, not even the
canvasElement
. The context is built-in and if you don't pass overrides, it will still be present. It is still possible to pass overrides to the context, if you'd like.In order for this to be possible, the portable stories API now adds a wrapper to your stories with a unique id based on your story id, such as:
This means that if you take DOM snapshots of your stories, they will be affected and you will have to update them.
The id calculation is based on different heuristics based on your Meta title and Story name. When using
composeStories
, the id can be inferred automatically. However, when usingcomposeStory
and your story does not explicitly have astoryName
property, the story name can't be inferred automatically. As a result, its name will be "Unnamed Story", resulting in a wrapper id like"#storybook-story-button--unnamed-story"
. If the id matters to you and you want to fix it, you have to specify theexportsName
property like so:Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>