ReleaseTooling: Exclude links to contributors' user profiles from changelog

[vanessayuenn]

What I did

This PR removes the explicit links to user profiles in generated changelogs.

It seems like GitHub releases now recognize GitHub handles in the changelog as contributors, and so we don't have to explicitly link to contributors' profiles anymore. In fact, doing so will cause GitHub to not recognize them properly and exclude them from the Contributors section (example).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

[yannbf]

LGTM! I'm wondering if this is consumed elsewhere, where the link does help?

[vanessayuenn]

LGTM! I'm wondering if this is consumed elsewhere, where the link does help?

I am not sure! @JReinhold do you know?

[JReinhold]

I don't think this should be solved at the data fetching layer but instead at the generation layer. pr.links.user would be misleading since it wouldn't actually contain a user link anymore.

I've changed the implementation to use pr.user instead of pr.links.user, let me know what you think @vanessayuenn, feel free to merge if you want to.