Addon-onboarding: Move onboarding to monorepo

[ndelangen]

Closes #26096

What I did

Merge this repo (https://github.com/storybookjs/addon-onboarding) into monorepo, with history.

• Fixes for typescript
• Fixes for compile
• Add to workspace
• Bump version installed by CLI
• Fix verdaccio config
• Sync versions
• Remove unused dependencies

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

I was able to manually test this to some degree, via:

• comment out these lines:

  storybook/code/addons/onboarding/src/manager.tsx

  Lines 17 to 30 in ba5cc6c

  	const hasButtonStories =
  	!!api.getData('example-button--primary') ||
  	!!document.getElementById('example-button--primary');
  	if (!hasButtonStories) {
  	console.warn(
  	`[@storybook/addon-onboarding] It seems like you have finished the onboarding experience in Storybook! Therefore this addon is not necessary anymore and will not be loaded. You are free to remove it from your project. More info: https://github.com/storybookjs/addon-onboarding#uninstalling`
  	);
  	return;
  	}
  	if (!isOnboarding || window.innerWidth < 730) {
  	return;
  	}

• add '@storybook/addon-onboarding', to code/ui/.storybook/main.ts's addon field
• compile packages
• run yarn storybook:ui --initial-path=/onboarding
• expect to see the onboarding UI

The second was to test would be to generate a sandbox that would normally show the onboarding addon.

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26176-sha-e072ee44. Try it out in a new sandbox by running npx [email protected] sandbox or in an existing project with npx [email protected] upgrade.

More information

Published version	0.0.0-pr-26176-sha-e072ee44
Triggered by	@valentinpalkovic
Repository	storybookjs/storybook
Branch	monorepo-migration
Commit	e072ee44
Datetime	Tue Feb 27 13:47:55 UTC 2024 (1709041675)
Workflow run	8065797916

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26176

[ndelangen]

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

[shilman]

I know this PR is just porting over the existing code, but any idea why this is needed? If there is a good reason we should add a comment here.

[ndelangen]

I have no idea.

We'd have to ask the authors @yannbf or @valentinpalkovic ?

[valentinpalkovic]

@shilman Could you please be a bit more precise about what exactly you are referring to? Are you saying that the managerEntries should just be exported in the src/preset.ts file like described here: https://storybook.js.org/docs/addons/writing-presets#root-level-presets? I don't understand the intention of your question.

[valentinpalkovic]

@ndelangen

Tested it in a Vite and Webpack project. In Webpack everything seems to be fine. In Vite, though, I can't continue on this step:

Somehow I don't get notified about the new Warning Story.

How to reproduce:

1. Checkout https://github.com/storybookjs/sandboxes/tree/next/react-vite/default-ts/before-storybook
2. npx [email protected] init
3. Go through the onboarding

Note: I also checked out the latest released version of addon-onboarding (2.0.0-next.2) and there it works for both, Webpack5 and Vite React-based projects.

[yannbf]

@ndelangen

Tested it in a Vite and Webpack project. In Webpack everything seems to be fine. In Vite, though, I can't continue on this step...

I just tested this in different projects, including the one mentioned in the repro, and had no issues:

[yannbf]

LGTM