Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-Native: Fixes for v8 compatibility #25678

Merged
merged 3 commits into from
Jan 26, 2024
Merged

React-Native: Fixes for v8 compatibility #25678

merged 3 commits into from
Jan 26, 2024

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 21, 2024

Closes N/A

What I did

  • Export PreviewWithSelection which was accidentally (?) removed
  • Export a proxy for the story store's getStoryContext
  • Set up react-native entry points for preview-api/manager-api

🦋 Canary release

This pull request has been released as version 0.0.0-pr-25678-sha-560d4141. Try it out in a new sandbox by running npx [email protected] sandbox or in an existing project with npx [email protected] upgrade.

More information
Published version 0.0.0-pr-25678-sha-560d4141
Triggered by @shilman
Repository storybookjs/storybook
Branch shilman/rn8
Commit 560d4141
Datetime Mon Jan 22 13:14:46 UTC 2024 (1705929286)
Workflow run 7611700495

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25678

@shilman shilman changed the title Preview-API: Export PreviewWithSelection React-Native: Fixes for v8 compatibility Jan 22, 2024
@shilman shilman marked this pull request as ready for review January 22, 2024 13:59
@shilman shilman added maintenance User-facing maintenance tasks react-native ci:normal labels Jan 22, 2024
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannyhw dannyhw mentioned this pull request Jan 24, 2024
5 tasks
@shilman shilman merged commit 806cbdd into next Jan 26, 2024
68 of 75 checks passed
@shilman shilman deleted the shilman/rn8 branch January 26, 2024 08:00
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks react-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants