Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction: Replace @storybook/jest by @storybook/test #25584

Merged
merged 8 commits into from
Jan 15, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jan 12, 2024

Closes #25583

What I did

Removed all remaining occurrences of @storybook/jest and replaced them by @storybook/test

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Jan 12, 2024
@valentinpalkovic valentinpalkovic added maintenance User-facing maintenance tasks ci:normal labels Jan 12, 2024
@valentinpalkovic valentinpalkovic force-pushed the valentin/replace-storybook-jest-by-test branch 3 times, most recently from 915bcc9 to 007c6dd Compare January 12, 2024 14:36
@valentinpalkovic valentinpalkovic force-pushed the valentin/replace-storybook-jest-by-test branch from 007c6dd to 595c32d Compare January 12, 2024 14:43
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@storybook/test 8.0.0-alpha.9 eval, environment +9 2.75 MB shilman
@storybook/client-logger 8.0.0-alpha.9 None +0 7.53 kB shilman
@storybook/core-events 8.0.0-alpha.9 None +0 70 kB shilman
@storybook/preview-api 8.0.0-alpha.9 None +0 318 kB shilman
@storybook/types 8.0.0-alpha.9 None +0 106 kB shilman
@storybook/channels 8.0.0-alpha.9 None +0 23.3 kB shilman
@storybook/instrumenter 8.0.0-alpha.9 environment +0 208 kB shilman

🚮 Removed packages: @storybook/[email protected]

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Uses eval @storybook/test 8.0.0-alpha.9

Next steps

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@valentinpalkovic valentinpalkovic changed the title Replace @storybook/jest by @storybook/test Interaction: Replace @storybook/jest by @storybook/test Jan 12, 2024
@valentinpalkovic valentinpalkovic force-pushed the valentin/replace-storybook-jest-by-test branch from 5b84482 to f503bc9 Compare January 15, 2024 09:29
@valentinpalkovic valentinpalkovic merged commit 8cc1d71 into next Jan 15, 2024
55 of 58 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/replace-storybook-jest-by-test branch January 15, 2024 10:31
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove any @storybook/jest occurences and use @storybook/test exclusively
2 participants