Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Check optionalDependencies for storybook versions #25406

Merged
merged 6 commits into from
Jan 10, 2024
Merged

CLI: Check optionalDependencies for storybook versions #25406

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
263ed62
fix: Check optionalDependencies for storybook versions
reyronald Jan 2, 2024
4974d6d
Merge branch 'next' into patch-1
ndelangen Jan 3, 2024
6e8f823
Formatting
reyronald Jan 3, 2024
b7d72d5
Update helpers.ts
reyronald Jan 3, 2024
f44e808
Merge branch 'next' into patch-1
reyronald Jan 3, 2024
94d113a
Merge branch 'next' into patch-1
reyronald Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion code/lib/cli/src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,11 @@ export async function adjustTemplate(templatePath: string, templateData: Record<
// Given a package.json, finds any official storybook package within it
// and if it exists, returns the version of that package from the specified package.json
export function getStorybookVersionSpecifier(packageJson: PackageJsonWithDepsAndDevDeps) {
const allDeps = { ...packageJson.dependencies, ...packageJson.devDependencies };
const allDeps = {
...packageJson.dependencies,
...packageJson.devDependencies,
...packageJson.optionalDependencies,
};
const storybookPackage = Object.keys(allDeps).find((name: string) => {
return storybookMonorepoPackages[name as keyof typeof storybookMonorepoPackages];
});
Expand Down