CLI: Never prompt for ESLint plugin #25289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
yannbf,
valentinpalkovic and
ndelangen
as code owners
valentinpalkovic
approved these changes
Dec 29, 2023
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
We've spent a lot of time on the onboarding flow, but the current prompt to install the ESLint plugin really sticks out like a sore thumb to me. Our CLI spends a lot of time downloading stuff, then I get this prompt for something minor, and then I have to wait for the rest of the installation process.
We should either always install it (this PR) or never. We could (and should!) also improve install perf AND improve the prompting UI but that is a bigger project.
Checklist for Contributors
Testing
Install Storybook in a fresh Vite project (or any project that uses ESlint).
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>