-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack: Fix exclude regex in react-docgen-loader #25030
Webpack: Fix exclude regex in react-docgen-loader #25030
Conversation
5580032
to
21b933d
Compare
…loader-for-windows Webpack: Fix exclude regex in react-docgen-loader (cherry picked from commit 0fa30d8)
…loader-for-windows Webpack: Fix exclude regex in react-docgen-loader (cherry picked from commit 0fa30d8)
…loader-for-windows Webpack: Fix exclude regex in react-docgen-loader (cherry picked from commit 0fa30d8)
…loader-for-windows Webpack: Fix exclude regex in react-docgen-loader (cherry picked from commit 0fa30d8)
…loader-for-windows Webpack: Fix exclude regex in react-docgen-loader (cherry picked from commit 0fa30d8)
…loader-for-windows Webpack: Fix exclude regex in react-docgen-loader (cherry picked from commit 0fa30d8)
I have the feeling that this change might have broken our setup.
Not sure if this is related at all, but started happening when updating from Storybook 7.5.3 to 7.6.1; Will check if happens on 7.6.0 |
Hmm, disabling |
@ovflowd Thanks for the bug report. Indeed, in 7.6.0 as soon as react-docgen encounters an error (in this case it tries to process a json file), it throws instead of swallowing it. I will change this behaviour tomorrow though to not throw an uncoverable error, but instead to just continue. I will release a hotfix tomorrow with the fix! |
Closes #25023
What I did
The exclude regex for the react-docgen-loader was not working properly for Windows users.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>