Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: Add aria-label to brand edit field #24981

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

MarioKavula
Copy link

Closes #24127

What I did

In this PR, the bug from the #24127 issue was fixed. The name variable of the table row was used as aria-label, so the narrator could read it when moving to input in narrator mode.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

The bug fix was manually tested with Windows 11 narrator in the default story sandbox.

Test:

  1. Run a sandbox for default template: yarn task
  2. Open Storybook in your browser
  3. Via the left navigation bar, navigate to Example->Button->Docs
  4. Start the narrator and navigate to the second row of the table with the name "label" and access the textarea input with the label "button".

Successful testing:

  • the narrator will now read the aria-label "Label" first and then the input value.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ShaunEvening ShaunEvening changed the title Mario kavula#24127 A11y: Add aria-label to brand edit field Nov 27, 2023
Comment on lines +55 to +57
"storyExplorer.storybookConfigDir": "./code/ui/.storybook",
"compile-hero.disable-compile-files-on-did-save-code": true,
"editor.inlineSuggest.showToolbar": "always"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add editor specific config

Suggested change
"storyExplorer.storybookConfigDir": "./code/ui/.storybook",
"compile-hero.disable-compile-files-on-did-save-code": true,
"editor.inlineSuggest.showToolbar": "always"
"storyExplorer.storybookConfigDir": "./code/ui/.storybook"

@yannbf
Copy link
Member

yannbf commented Jan 2, 2024

Hey there @MarioKavula thanks for your contribution! It looks pretty good, but the E2E tests are failing. Would you mind taking a look at them?

@yannbf
Copy link
Member

yannbf commented Feb 5, 2024

Hey @MarioKavula, did you manage to take a look into the failures? I updated the branch and they're still happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: While navigating to “Brand” edit field narrator is not announcing the label name of the edit field.
3 participants