Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestBuild: Disable docs related stuff for test builds #24691

Merged
merged 19 commits into from
Nov 10, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Nov 2, 2023

What I did

I added another flag based on the --test flag.

This one will cause addons to not be loaded.

I also added a flag to remove the .mdx stories-entries
I also added a flag to disable autodocs-entries from being created by the indexer.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen changed the title FastBuild: Filter all addons away when removeAllAddons is true TestBuild: Filter all addons away when removeAllAddons is true Nov 2, 2023
@ndelangen ndelangen self-assigned this Nov 2, 2023
@kasperpeulen kasperpeulen force-pushed the norbert/fast-build-no-docs branch from 96c1625 to 3fd6000 Compare November 3, 2023 14:43
@kasperpeulen kasperpeulen changed the title TestBuild: Filter all addons away when removeAllAddons is true TestBuild: Disable docs related stuff for test builds Nov 3, 2023
Base automatically changed from norbert/fast-build-toggles to next November 3, 2023 15:38
@ndelangen
Copy link
Member Author

@kasperpeulen approve?

@ndelangen ndelangen merged commit e8d9ac7 into next Nov 10, 2023
60 checks passed
@ndelangen ndelangen deleted the norbert/fast-build-no-docs branch November 10, 2023 07:57
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants