Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Remove sb extract command #24653

Merged
merged 4 commits into from
Nov 1, 2023
Merged

CLI: Remove sb extract command #24653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6db1a34
remove extract
ndelangen Nov 1, 2023
64a9a8c
correction of code-comment
ndelangen Nov 1, 2023
1ada451
fix lockfile
ndelangen Nov 1, 2023
3f15a08
cleanup
ndelangen Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/lib/channels/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type Options = Config & {
/**
* Creates a new browser channel instance.
* @param {Options} options - The options object.
* @param {Page} options.page - The puppeteer page instance.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably AI generated nonsense 😅

* @param {Page} options.page - page identifier.
* @param {ChannelTransport[]} [options.extraTransports=[]] - An optional array of extra channel transports.
* @returns {Channel} - The new channel instance.
*/
Expand Down
2 changes: 0 additions & 2 deletions code/lib/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"ora": "^5.4.1",
"prettier": "^2.8.0",
"prompts": "^2.4.0",
"puppeteer-core": "^2.1.1",
"read-pkg-up": "^7.0.1",
"semver": "^7.3.7",
"simple-update-notifier": "^2.0.0",
Expand All @@ -100,7 +99,6 @@
"devDependencies": {
"@types/cross-spawn": "^6.0.2",
"@types/prompts": "^2.0.9",
"@types/puppeteer-core": "^2.1.0",
"@types/semver": "^7.3.4",
"@types/util-deprecate": "^1.0.0",
"boxen": "^5.1.2",
Expand Down
88 changes: 0 additions & 88 deletions code/lib/cli/src/extract.ts
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions code/lib/cli/src/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import program from 'commander';
import path from 'path';
import chalk from 'chalk';
import envinfo from 'envinfo';
import leven from 'leven';
Expand All @@ -12,7 +11,6 @@ import type { CommandOptions } from './generators/types';
import { initiate } from './initiate';
import { add } from './add';
import { migrate } from './migrate';
import { extract } from './extract';
import { upgrade, type UpgradeOptions } from './upgrade';
import { sandbox } from './sandbox';
import { link } from './link';
Expand Down Expand Up @@ -136,15 +134,6 @@ command('migrate [migration]')
});
});

command('extract [location] [output]')
.description('extract stories.json from a built version')
.action((location = 'storybook-static', output = path.join(location, 'stories.json')) =>
extract(location, output).catch((e) => {
logger.error(e);
process.exit(1);
})
);

command('sandbox [filterValue]')
.alias('repro') // for backwards compatibility
.description('Create a sandbox from a set of possible templates')
Expand Down
Loading