Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Remove file URL examples from storyshots-puppeteer docs #24361

Merged

Conversation

irangarcia
Copy link
Contributor

@irangarcia irangarcia commented Oct 3, 2023

What I did

Remove file URL examples from storyshots-puppeteer docs since the support for it was dropped on v7 as stated here

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@irangarcia irangarcia requested a review from ndelangen as a code owner October 3, 2023 17:48
@irangarcia irangarcia changed the title Remove file URL examples from storyshots-puppeteer docs Documentation: Remove file URL examples from storyshots-puppeteer docs Oct 4, 2023
@ndelangen ndelangen added documentation ci:docs Run the CI jobs for documentation checks only. labels Oct 6, 2023
@jonniebigodes jonniebigodes self-assigned this Oct 6, 2023
@ndelangen ndelangen merged commit 89af803 into storybookjs:next Oct 9, 2023
@github-actions github-actions bot mentioned this pull request Oct 9, 2023
24 tasks
@irangarcia irangarcia deleted the docs/remove-deprecated-file-url branch October 9, 2023 11:37
@github-actions github-actions bot mentioned this pull request Oct 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants