Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major updates for devDependencies #2418

Merged
merged 2 commits into from
Dec 4, 2017
Merged

Major updates for devDependencies #2418

merged 2 commits into from
Dec 4, 2017

Conversation

Hypnosphi
Copy link
Member

Fixes #2405 & #2411

This also includes removal of some unused lodash.* dependencies and fixes spelling of word "Emitter"

@@ -112,8 +112,7 @@
"yarn lint:js --fix",
"git add"
]
},
"verbose": true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get verbose output, run yarn precommit --debug

@Hypnosphi Hypnosphi added cleanup Minor cleanup style change that won't show up in release changelog dependencies:update maintenance User-facing maintenance tasks labels Dec 3, 2017
@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #2418 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2418   +/-   ##
=======================================
  Coverage   16.64%   16.64%           
=======================================
  Files         302      302           
  Lines        7769     7769           
  Branches      773      771    -2     
=======================================
  Hits         1293     1293           
- Misses       5865     5883   +18     
+ Partials      611      593   -18
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Date/index.js 23.52% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.88% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/shortcuts_help.js 12.85% <0%> (ø) ⬆️
...les/ui/components/left_panel/stories_tree/index.js 38.46% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/routed_link.js 21.15% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1446b47...2645a0f. Read the comment docs.

@Hypnosphi Hypnosphi merged commit ed8ea6e into master Dec 4, 2017
@Hypnosphi Hypnosphi deleted the update-deps branch December 4, 2017 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog dependencies maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants