Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-actions: display enumerable properties from prototype chain #2401

Closed
wants to merge 2 commits into from

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Nov 29, 2017

Issue: #1945
Some builtin object types (e.g. File) have valuable enumerable properties in their prototypes

How to test

Open cra example "Addon Actions / File object as payload", click the button

image

@Hypnosphi Hypnosphi force-pushed the action-list-all-enumerable-props branch from bcbeffa to ad89dca Compare November 29, 2017 22:57
@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #2401 into release/3.3 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #2401      +/-   ##
===============================================
+ Coverage        21.59%   21.59%   +<.01%     
===============================================
  Files              339      339              
  Lines             7109     7108       -1     
  Branches           872      882      +10     
===============================================
  Hits              1535     1535              
+ Misses            4918     4912       -6     
- Partials           656      661       +5
Impacted Files Coverage Δ
addons/actions/src/util.js 19.09% <100%> (+0.17%) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 51.85% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 50% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.21% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ad63f...ad89dca. Read the comment docs.

@Hypnosphi
Copy link
Member Author

Superseded by #2438

@Hypnosphi Hypnosphi closed this Dec 5, 2017
@ndelangen ndelangen deleted the action-list-all-enumerable-props branch December 9, 2017 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant