Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Migrate @storybook/api to strict types #23848

Closed
wants to merge 3 commits into from

Conversation

stilt0n
Copy link
Contributor

@stilt0n stilt0n commented Aug 16, 2023

Part of #22176

What I did

Change tsconfig.json of @storybook/api to strict type-checking for completeness' sake. Doesn't really do much because @storybook/api is just re-exporting @storybook/manager-api.

How to test

See if CI type check task runs clean

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen added maintenance User-facing maintenance tasks ci:normal labels Aug 16, 2023
@kasperpeulen kasperpeulen self-assigned this Aug 16, 2023
@ndelangen
Copy link
Member

Thank you for your time and effort @stilt0n

This package has been deprecated and removed in 8.0.
I'm sorry but that means I can't merge your PR.

@ndelangen ndelangen closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants