-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Fix snippets regarding module resolution #23602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonniebigodes
added
ci:docs
Run the CI jobs for documentation checks only.
patch:yes
Bugfix & documentation PR that need to be picked to main branch
and removed
ci:docs
Run the CI jobs for documentation checks only.
labels
Jul 25, 2023
jonniebigodes
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yannbf, thanks for this small tweak to the documentation and finding that typo. All is good on my end. I've labeled it patch yes so that it can be ported back to the main branch and made available to the 7.0 docs
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
This was referenced Jul 25, 2023
Closed
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
30 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
Closed
32 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…-documentation Documentation: Fix snippets regarding module resolution (cherry picked from commit d4e6098)
kasperpeulen
removed
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23601
What I did
The documentation had a missing import, and users were hitting errors by copy pasting it. This PR fixes that.
How to test
Reviewing the documentation should be enough
Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>