Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix snippets regarding module resolution #23602

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 25, 2023

Closes #23601

What I did

The documentation had a missing import, and users were hitting errors by copy pasting it. This PR fixes that.

How to test

Reviewing the documentation should be enough

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes added ci:docs Run the CI jobs for documentation checks only. patch:yes Bugfix & documentation PR that need to be picked to main branch and removed ci:docs Run the CI jobs for documentation checks only. labels Jul 25, 2023
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yannbf, thanks for this small tweak to the documentation and finding that typo. All is good on my end. I've labeled it patch yes so that it can be ported back to the main branch and made available to the 7.0 docs

@jonniebigodes jonniebigodes merged commit d4e6098 into next Jul 25, 2023
@jonniebigodes jonniebigodes deleted the yann/fix-module-resolution-documentation branch July 25, 2023 16:08
storybook-bot pushed a commit that referenced this pull request Jul 25, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 25, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 25, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
30 tasks
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 27, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 27, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 27, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 28, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 28, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 28, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 31, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Jul 31, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 3, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
32 tasks
storybook-bot pushed a commit that referenced this pull request Aug 4, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 8, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Path is not defined
3 participants