UI: Fix target id in searchfield label #23464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js#23463) The for attribute value was not set to match the hardcoded value used for the search input id.
|
I might need some guidance with the DangerJS failures in the build, I'm not sure I should be making changes to package-lock.json files. I made no changes to dependencies, and the project seems to be managed by yarn. |
yannbf
requested review from
ndelangen,
JReinhold,
cdedreuille and
tmeasday
as code owners
ndelangen
changed the title
yannbf
changed the title
yannbf
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Hey @plumpNation thank you so much for this contribution, and sorry it took us time to review it. Looks great! <3
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23463
What I did
The for attribute value was not set to match the hardcoded value used for the search input id. This is invalid HTML and creates an error issue in chrome dev tools "Issues" tab.
How to test
yarn task --task sandbox --start-from auto --template react-vite/default-tsChecklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]