Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Fix regex that replaces globs for js/ts stories #23184

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Build: Fix regex that replaces globs for js/ts stories #23184

merged 2 commits into from
Jun 22, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jun 22, 2023 •
edited
Loading

Closes #

What I did

Fixing a regression caused in #23125

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added the build Internal-facing build tooling & test updates label Jun 22, 2023
@yannbf yannbf requested a review from ndelangen June 22, 2023 08:42
@ndelangen ndelangen self-assigned this Jun 22, 2023
@ndelangen
Copy link
Member

@yannbf the missing docs page is a problem. Can you fix it?

@yannbf yannbf added the ci:daily Run the CI jobs that normally run in the daily job. label Jun 22, 2023
@ndelangen ndelangen merged commit b604995 into next Jun 22, 2023
@ndelangen ndelangen deleted the fix/js-sandboxes branch June 22, 2023 10:07
@github-actions github-actions bot mentioned this pull request Jun 22, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannbf @ndelangen