-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Prebundle node-logger and make it CJS only #23109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me 👍
In my experiment to change the bundle script for CJS dist, the NX remote cache was corrupted somehow. |
a3fc22f
to
8cde3f3
Compare
@@ -24,13 +24,11 @@ | |||
".": { | |||
"types": "./dist/index.d.ts", | |||
"node": "./dist/index.js", | |||
"require": "./dist/index.js", | |||
"import": "./dist/index.mjs" | |||
"require": "./dist/index.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a setup (nx / vite) where I need the "import" declaration -- in this case, adding back "import": "./dist/index.js"
would solve my issue while still using a "prebundled" version of node-logger?
This broke our upgrade from storybook 7.0.24 to 7.4.46
I was alerted about this stack trace by @integrayshaun :
We traced it to
wide-align/align.js
indeed callingrequire('string-width')
, which is not allowed by JS law.I prebundled
node-logger
, meaning all dependencies are now bundled in.