Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release tooling: Give the full commit hash to the github API #23046

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Release tooling: Give the full commit hash to the github API #23046

merged 1 commit into from
Jun 13, 2023

Conversation

kasperpeulen
Copy link
Contributor

What I did

Use the full commit hash for the github API, as it returns null with the short one sometimes (might be a clash??)

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen added build Internal-facing build tooling & test updates patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 13, 2023
@kasperpeulen kasperpeulen force-pushed the kasper/use-full-oid branch from f89b77d to b450706 Compare June 13, 2023 12:59
@kasperpeulen kasperpeulen merged commit de18fcc into next Jun 13, 2023
@kasperpeulen kasperpeulen deleted the kasper/use-full-oid branch June 13, 2023 12:59
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 13, 2023
kasperpeulen added a commit that referenced this pull request Jun 13, 2023
@kasperpeulen
Merge pull request #23046 from storybookjs/kasper/use-full-oid
1ca9621 
Release tooling: Give the full commit hash to the github API
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Merged
42 tasks
@shilman shilman removed the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 14, 2023
@github-actions github-actions bot mentioned this pull request Jun 14, 2023
Merged
69 tasks
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 15, 2023
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@JReinhold JReinhold Awaiting requested review from JReinhold

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasperpeulen @shilman @JReinhold