Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Fix playwright issues on main #22999

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Build: Fix playwright issues on main #22999

merged 3 commits into from
Jun 9, 2023

Conversation

kasperpeulen
Copy link
Contributor

What I did

Cherry picking norbert's work on playwright to main

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

ndelangen added 2 commits June 9, 2023 12:56
@ndelangen @kasperpeulen
Merge pull request #22992 from storybookjs/shilman/upgrade-playwright
40e1e88 
Build: Upgrade playwright to 1.35.0
@ndelangen @kasperpeulen
Merge pull request #22998 from storybookjs/norbert/playwright-fix
d09dda9 
Build: Remove `playwright` and `playwright-core`, but keep the resolutions
@kasperpeulen kasperpeulen requested a review from a team as a code owner June 9, 2023 11:00
@kasperpeulen kasperpeulen requested a review from ndelangen June 9, 2023 11:00
@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label Jun 9, 2023
@kasperpeulen kasperpeulen changed the base branch from next to main June 9, 2023 11:00
@ndelangen @kasperpeulen
Merge pull request #22996 from storybookjs/norbert/upgrade-addon-bench
b9bc611 
Build: Fix CI with conflicting playwright version
@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
@playwright/test ⬆️ 1.32.3...1.35.0 None +1/-1 10 MB aslushnikov

🚮 Removed packages: [email protected]

Footnotes

  1. https://docs.socket.dev ↩

@kasperpeulen kasperpeulen merged commit 73ebe47 into main Jun 9, 2023
@kasperpeulen kasperpeulen deleted the kasper/playwright-main branch June 9, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperpeulen @ndelangen