Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Simplify migration-guide #22986

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Docs: Simplify migration-guide #22986

merged 2 commits into from
Jun 13, 2023

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Jun 8, 2023

What I did

Related to #22863, this PR simplifies the 7.0 migration guide to most effectively highlight significant breaking changes

How to test

  1. Follow the steps in the contributing instructions for this branch, simplify-migration-guide-cli

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kylegach kylegach added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 8, 2023
@kylegach kylegach self-assigned this Jun 8, 2023
kylegach
kylegach commented Jun 8, 2023
View reviewed changes
docs/migration-guide.md

- [Webpack4 support discontinued](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack4-support-discontinued)
- [IE11 support discontinued](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#modern-browser-support)
- [Minimum supported version of node is 16](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#dropped-support-for-node-15-and-below)
- [Babel mode v7 exclusively](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#babel-mode-v7-exclusively)
- [Some community addons might not work yet](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#specific-instructions-for-addon-users)
- Storybook CLI changes:
- [Start and build binaries removed](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#start-storybook--build-storybook-binaries-removed)
- [`DLL` flags removed](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#removed-dll-flags)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this one because it's not a commonly-used feature.

kylegach
kylegach commented Jun 8, 2023
View reviewed changes
docs/migration-guide.md
- Storybook CLI changes:
- [Start and build binaries removed](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#start-storybook--build-storybook-binaries-removed)
- [`DLL` flags removed](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#removed-dll-flags)
- [`use-npm` flag deprecated](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#cli-option---use-npm-deprecated)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this one because a deprecation is not a breaking change.

@kylegach kylegach marked this pull request as ready for review June 8, 2023 17:09
@kylegach kylegach requested a review from jonniebigodes June 8, 2023 17:09
@kylegach kylegach changed the title Simplify migration-guide Docs: Simplify migration-guide Jun 8, 2023
@kylegach kylegach force-pushed the simplify-migration-guide-cli branch from 314dd69 to b1876d3 Compare June 9, 2023 21:23
@kylegach kylegach force-pushed the simplify-migration-guide-cli branch from b1876d3 to 8b6316b Compare June 12, 2023 22:20
jonniebigodes
jonniebigodes approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for addressing the feedback. Appreciate it

@jonniebigodes jonniebigodes merged commit 28197ea into next Jun 13, 2023
@jonniebigodes jonniebigodes deleted the simplify-migration-guide-cli branch June 13, 2023 11:56
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Merged
42 tasks
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
5744efd 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
400b21b 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
6ddc7bf 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Merged
69 tasks
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
a611a7d 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
21e2974 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
e160ae4 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
632c4e4 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
d25e7ce 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
cb021b2 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
cbd75e6 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
3887d57 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
e44f81f 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
d51d021 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
4d6f0c3 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
11791a4 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
726574e 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@jonniebigodes @github-actions
Merge pull request #22986 from storybookjs/simplify-migration-guide-cli
d93779e 
Docs: Simplify `migration-guide`
(cherry picked from commit 28197ea)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 15, 2023
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonniebigodes jonniebigodes jonniebigodes approved these changes

Assignees

@kylegach kylegach

Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylegach @jonniebigodes @JReinhold