Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Remove usage of <LinkWithVersion> #22966

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Jun 7, 2023

What I did

How to test

  1. Follow the steps in the contributing instructions for this branch, versioned-docs-links
  2. Check the "previous documentation" links for thewriting-docs/mdx and configure/babel pages
  3. Check those same links when rendered on GitHub

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kylegach kylegach added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 7, 2023
@kylegach kylegach self-assigned this Jun 7, 2023
@kylegach kylegach requested a review from jonniebigodes June 7, 2023 16:26
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to look into this and update the documentation. It looks great. Merge away when you're able.

@kylegach kylegach merged commit 1872214 into next Jun 7, 2023
@kylegach kylegach deleted the versioned-docs-links branch June 7, 2023 17:44
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 8, 2023
shilman pushed a commit that referenced this pull request Jun 8, 2023
[Documentation]: Remove usage of <LinkWithVersion>
kylegach added a commit to storybookjs/frontpage that referenced this pull request Jun 8, 2023
- No longer used, per #555 & storybookjs/storybook#22966
- Simplify `relativeToRootLinks`
@JReinhold JReinhold changed the title [Documentation]: Remove usage of <LinkWithVersion> Documentation: Remove usage of <LinkWithVersion> Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants