Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Silence compodoc when running storybook with --quiet #22957

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jun 7, 2023

Relates to #22871

What I did

Compodoc logs will now be suppressed when running storybook with --quiet

How to test

  1. Create an angular sandbox for template, e.g. yarn task --task sandbox --start-from auto --template angular-cli/default-ts
  2. Run yarn storybook
  3. See 12391203912 compodoc logs
  4. Run yarn storybook --quiet
  5. See 1 compodoc log

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added cli angular patch:yes Bugfix & documentation PR that need to be picked to main branch ci:merged Run the CI jobs that normally run when merged. labels Jun 7, 2023
@yannbf yannbf requested a review from a team as a code owner June 7, 2023 10:50
@yannbf yannbf requested a review from valentinpalkovic June 7, 2023 10:50
@yannbf yannbf added the bug label Jun 7, 2023
@yannbf yannbf merged commit a951917 into next Jun 7, 2023
@yannbf yannbf deleted the feat/silence-compodoc-on-quiet-flag branch June 7, 2023 13:01
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 8, 2023
shilman pushed a commit that referenced this pull request Jun 8, 2023
…uiet-flag

Angular: Silence compodoc when running storybook with --quiet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug ci:merged Run the CI jobs that normally run when merged. cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants