Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandboxes: Fix scripts when pre-existing NODE_OPTIONS contains whitespaces #22677

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Sandboxes: Fix scripts when pre-existing NODE_OPTIONS contains whitespaces #22677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
578cbbf
fix: sandbox package.json when pre-existing NODE_OPTIONS value contai…
sookmax May 22, 2023
230846d
Merge branch 'next' into node-options-quotes
JReinhold Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/tasks/sandbox-parts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export const init: Task['run'] = async (
}

const nodeOptionsString = nodeOptions.join(' ');
const prefix = `NODE_OPTIONS="${nodeOptionsString}" STORYBOOK_TELEMETRY_URL="http://localhost:6007/event-log"`;
const prefix = `NODE_OPTIONS='${nodeOptionsString}' STORYBOOK_TELEMETRY_URL="http://localhost:6007/event-log"`;

await updatePackageScripts({
cwd,
Expand Down