CLI: Fix copyTemplate failures on init
#22375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
bug
patch:yes
shilman
reviewed
May 8, 2023
| @@ -10,7 +10,9 @@ const generator: Generator = async (packageManager, npmOptions, options) => { | |||
| }); | |||
|
|
|||
| const templateDir = join(getCliDir(), 'templates', 'server'); | |||
There was a problem hiding this comment.
We can just get rid of this block of code entirely. I just tested it out on a sample project and will be adding a telescoping PR to do it.
shilman
changed the title
init by guarding against copyTemplate failuresinit
Merged
Server: Add json indexer to preset Co-authored-by: Donnie Flood <[email protected]>
…okjs/storybook into shilman/20627-fix-server-indexer
…ndexer Server: Add json indexer
CLI: Fix server init
…into norbert/fix-22348
shilman
added a commit
that referenced
this pull request
May 9, 2023
CLI: Fix copyTemplate failures on `init`
shilman
added
the
patch:done
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22348
What I did
Add guards against projectType being an unknown value
Add guards against templateDir being a location that doesn't exist
How to test
I'm not exactly sure how to reproduce the error, but 1 way that would work for sure would be to set a
projectTypeto a odd value in an angular project. I don't think there are any other proper values other thenapplicationandlibrarybut if there are, then that would have caused issues in the past. After this PR that should default back toapplication. I assume this is the correct default.If the templateDir cannot be found at all, we'll just skip it, this MIGHT cause those storybook to fail to start or build, but that's hard to tell without a full reproduction I can follow.
...either way that would become a follow-up issue then.