Migrate: skip the automigration for gf markdown when user isn't using mdx #22186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…automigration for gf markdown
ndelangen
changed the title
5 tasks
yannbf
reviewed
Apr 21, 2023
| @@ -22,9 +25,27 @@ export const mdxgfm: Fix<Options> = { | |||
| return null; | |||
| } | |||
|
|
|||
| const hasMDXFiles = await mainConfig?.stories?.reduce(async (acc, item) => { | |||
There was a problem hiding this comment.
I wonder if you could just do the same as this automigration: https://github.com/storybookjs/storybook/blob/next/code/lib/cli/src/automigrate/fixes/mdx-1-to-2.ts#L49
There was a problem hiding this comment.
That seems worse? considering it's not using the glob patterns set in main.ts, and will ignore any MDX files not following the .stories.mdx pattern.
There was a problem hiding this comment.
Alright sounds good, maybe the other automigration should follow this pattern then
ndelangen
added
the
patch:yes
shilman
added
bug
patch:done
shilman
pushed a commit
that referenced
this pull request
May 3, 2023
Migrate: skip the automigration for gf markdown when user isn't using mdx
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22167
What I did
I added a check if the user is actually using MDX files.
If they do not.. we should skip the automigration.
How to test
Run the automigration on a project that has no MDX files