Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create channels URL from window.location #22053

Closed
wants to merge 9 commits into from
Closed

Create channels URL from window.location #22053

wants to merge 9 commits into from

Conversation

medihack
Copy link
Contributor

Closes #20068

What I did

Create channels URL dynamically on the client by using the window location object.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["bug"]

@medihack
Copy link
Contributor Author

I simply got rid of SERVER_CHANNEL_URL. I don't see a case where it is really needed anymore, but not sure about that.

@medihack
Copy link
Contributor Author

Hm, something is strange with the commit history here. Creating a new PR.

@medihack medihack closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Hardcoded host for server channel url prevents usage of custom host
5 participants