Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Wix example in docs #2191

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Feature Wix example in docs #2191

merged 1 commit into from
Oct 31, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 31, 2017

Issue: N/A

What I did

Add wix styleguide

How to test

yarn bootstrap:docs
yarn docs:dev
open http://localhost:8000/examples/

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman requested a review from a team October 31, 2017 13:22
Copy link
Member

@marchdoe marchdoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

Merging #2191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2191   +/-   ##
=======================================
  Coverage   21.43%   21.43%           
=======================================
  Files         263      263           
  Lines        5803     5803           
  Branches      698      688   -10     
=======================================
  Hits         1244     1244           
- Misses       4024     4055   +31     
+ Partials      535      504   -31
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e0e92...37a437f. Read the comment docs.

@shilman shilman merged commit fa99f37 into master Oct 31, 2017
@shilman shilman deleted the shilman/wix-example branch October 31, 2017 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants