-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRA Example Cleanup - Info #2143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2143 +/- ##
======================================
Coverage 21.4% 21.4%
======================================
Files 263 263
Lines 5812 5812
Branches 694 706 +12
======================================
Hits 1244 1244
+ Misses 4041 3996 -45
- Partials 527 572 +45
Continue to review full report at Codecov.
|
danielduan
force-pushed
the
dd/cra-reorg
branch
from
October 29, 2017 00:23
9f0efcc
to
0e20787
Compare
ndelangen
approved these changes
Oct 29, 2017
Hypnosphi
approved these changes
Oct 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#1750
What I did
*.stories.js
so future stories could be separated easilyHow to test
Is this testable with jest or storyshots?
yes
Does this need a new example in the kitchen sink apps?
this is it
Does this need an update to the documentation?
no
If your answer is yes to any of these, please make sure to include it in your PR.