Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRA Example Cleanup - Info #2143

Merged
merged 7 commits into from
Oct 29, 2017
Merged

CRA Example Cleanup - Info #2143

merged 7 commits into from
Oct 29, 2017

Conversation

danielduan
Copy link
Member

@danielduan danielduan commented Oct 28, 2017

Issue:

#1750

What I did

  • cleaned up info examples and added new examples for different options
  • turned on automatic import for *.stories.js so future stories could be separated easily
  • will cleanup existing info usages and move old examples to a deprecated kind later

How to test

Is this testable with jest or storyshots?
yes

Does this need a new example in the kitchen sink apps?
this is it

Does this need an update to the documentation?
no

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Oct 28, 2017

Codecov Report

Merging #2143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2143   +/-   ##
======================================
  Coverage    21.4%   21.4%           
======================================
  Files         263     263           
  Lines        5812    5812           
  Branches      694     706   +12     
======================================
  Hits         1244    1244           
+ Misses       4041    3996   -45     
- Partials      527     572   +45
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 9.09% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a6308...859d669. Read the comment docs.

@danielduan danielduan requested a review from a team October 29, 2017 00:02
@danielduan danielduan merged commit ec07bb0 into master Oct 29, 2017
@danielduan danielduan deleted the dd/cra-reorg branch October 29, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants