Blocks: Story stories #19805
Merged
Blocks: Story stories #19805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
commented
Nov 11, 2022
JReinhold
commented
Nov 11, 2022
JReinhold
requested review from
shilman and
tmeasday
and removed request for
shilman
JReinhold
commented
Nov 11, 2022
tmeasday
approved these changes
Nov 13, 2022
Comment on lines
+96
to
+98
| // TODO: types suggest that <Story /> can take ProjectAnnotations, but it doesn't seem to do anything with them | ||
| // Such as parameters, decorators, etc. | ||
| // they seem to be taken from the story itself, and not from the <Story /> call |
There was a problem hiding this comment.
Probably for portable docs, and wouldn't apply in non-external. We should probably talk this through.
…torybook into jeppe/sb-898-blocks-story
…torybook into jeppe/sb-898-blocks-story
JReinhold
commented
Nov 16, 2022
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "extends": "../../tsconfig.json", | |||
| "compilerOptions": { | |||
| "module": "esnext", | |||
There was a problem hiding this comment.
@ndelangen I changed this so TS wouldn't complain that I was referencing import.meta.env, do you know if changing this will break something somewhere else? Or does tsup ignore this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on top of #19804
This PR adds stories for the Story block, by using the Boolean Control as an example - therefore also adding a few stories to that one.
A major find from this work is that the Story block doesn't actually support overriding any annotations with props, like parameters or args - even though the typings says it does. This is an ommision that will be fixed in another PR.